Install ShellCheck on the boxes, or ship the lane skipping loudly? nf-o3wb ← Beads

closed priority 2 task unassigned needs:direction

Twinned from https://github.com/cfsh/ninefold/issues/438 by tools/beads/import_github.py's reconcile pass.

Raised by #436 (design 001 piece 1). Design 001 §3.1 cites a ShellCheck 0.11.0 run over all 15 tracked scripts, so the tool was available to the design session — but command -v shellcheck on the sandbox box returns nothing. §5.1 gives the **/*.sh lane as *"the enforcement point §3.1's concession otherwise lacks"*, and it currently cannot run, while ~16 scripts / ~2,600 lines of shell stay live across an ~11-PR migration.

A — accept the skip (recommended; this is what #436 ships today). ./presubmit.py --all prints shellcheck not installed — 16 shell script(s) UNCHECKED, and --doctor lists it as optional with an install link. Loud, never green-on-nothing, no machine change. Cost: those scripts stay unlinted until each one migrates to Python.

B — install ShellCheck on both boxes. The lane simply starts working; no code change needed (<https://github.com/koalaman/shellcheck/releases>;). Cost: one install per box, and --doctor should then promote it from optional to required.

Default ships if unanswered — nothing is blocked on this.

Dependencies

None.

Comments

No comments.

Add a comment