run_godot_tests.sh: Windows-only Godot glob, and it is a shell script with logic nf-ectu ← Beads

open priority 2 task unassigned

Twinned from https://github.com/cfsh/ninefold/issues/569 by tools/beads/import_github.py's reconcile pass.

Found while making Godot discovery platform-aware for #566. Left out of that PR deliberately: it is two concerns, and neither is on the merge path.

1. The glob is Windows-only. run_godot_tests.sh:18:

```bash GODOT="${GODOT_CONSOLE:-$(ls C:/Tools/Godot/*/*_console.exe 2>/dev/null | head -1 || true)}" ```

_console.exe is a Windows-subsystem artifact — Linux ships one binary that always writes to stdout — so on the WSL box this matches nothing and the script exits 2 with "set GODOT_CONSOLE", on a machine where Godot is installed and working at /opt/godot. Every other Godot lookup now goes through nflib.godot.find(), which handles both platforms; this is the last site that does not.

2. It is checked-in shell holding logic. Per notes/shell-policy.md a .sh may resolve paths and exec one thing; this one globs, branches on two conditions and emits a diagnostic. So the fix is probably not "add a Linux glob" but "make it Python", at which point it can just call nflib.godot.

Careful — two properties are pinned by tests and were paid for:

Unclaimed.

Dependencies

None.

Comments

No comments.

Add a comment