presubmit --all: python lane broken on main, merge_pr_test.BdSyncChokepointTest references undefined _T1Gh nf-b93u ← Beads

closed priority 2 task unassigned

Twinned from https://github.com/cfsh/ninefold/issues/1131 by tools/beads/import_github.py's reconcile pass.

tools/pr/merge_pr_test.py's BdSyncChokepointTest (added in #1107, commit 412521d, design 011 T5: cross-machine bd sync) references _T1Gh() in four tests — test_a_successful_merge_pulls_then_pushes, test_a_failed_pull_skips_the_push_and_does_not_fail_the_merge, test_a_failed_push_does_not_fail_the_merge, test_bd_not_installed_does_not_fail_the_merge — but no _T1Gh class exists anywhere in the file. `python3 -m unittest tools.pr.merge_pr_test.BdSyncChokepointTest` fails all four with NameError: name '_T1Gh' is not defined.

This is on main right now (confirmed via git stash back to a clean feat/doctor-bd-workspace checkout at 412521d, no other changes) — every session's ./presubmit.py --all python lane currently fails because of it.

Fix is presumably a rename/refactor that missed these four call sites, or a helper class that was meant to land alongside them and didn't — whoever picks this up should check #1107's own diff and intent first.

Unclaimed — filed per CLAUDE.md's "strategic uplifts: file them, don't claim them." Found while validating an unrelated presubmit.py change (#1128) — presubmit.py --all's python lane is otherwise green.

Dependencies

None.

Comments

No comments.

Add a comment