Releases cannot be cut from a Linux box nf-4cc7 ← Beads

open priority 2 task unassigned

Twinned from https://github.com/cfsh/ninefold/issues/570 by tools/beads/import_github.py's reconcile pass.

Found while doing #566. Deliberately not fixed there, because it is a feature rather than a path bug and "fixing the glob" would produce a tool that finds an engine it cannot export with.

tools/release/release.py has its own Godot lookup, separate from the four that #566 consolidated into nflib.godot:

```python GODOT_GLOBS = ( "Godot_v4.*-stable_mono_win64_console.exe", "Godot_v4.*-stable_mono_win64/Godot_v4.*-stable_mono_win64_console.exe", ) GODOT_ROOT = "C:/Tools/Godot" ```

Two reasons it was left alone:

  1. The globs are version-pinned AND platform-pinned on purposeGodot_v4.*-stable_mono_win64. Swapping in nflib.godot.INSTALL_ROOT would make the root portable while the patterns still matched nothing on Linux, which is worse than today: it would look fixed.
  2. Export templates are the actual blocker. The release ships {win,linux} builds (PUBLIC_BASE), and producing the Windows one needs the Windows export templates. Whether a Linux box can cut the full release, or only the Linux half, is a real question with a real answer that someone has to decide.

Also Windows-shaped in that file, if this is ever picked up: RCLONE_FALLBACK = "C:/Tools/rclone/rclone.exe", and CREDS_HELP tells the operator to use setx.

notes/machines.md now states plainly that releases cannot be cut on the WSL box, so nobody should be surprised by it in the meantime.

Unclaimed.

Dependencies

None.

Comments

No comments.

Add a comment