improve sample waveform rendering nf-1q7k ← Beads

closed priority 2 task unassigned

Twinned from https://github.com/cfsh/ninefold/issues/165 by tools/beads/import_github.py's reconcile pass.

From https://github.com/cfsh/ninefold/pull/158

"Honest note: the probe's d-pad routing on this stack kept missing the instrument chips, so the sample-selected screenshot isn't attached — the change is 20 lines feeding stream.Data to the existing view. F5: pick cable, see the waveform; tap different keys and watch it re-render. "

See if you can fix the screenshotting system / inputs so you can get some screenshots of the waveforms.

Then observe they are quite jagged for e.g. Cable and Grand Piano - I am not sure if this is intentional.

Would be great to show the wave of the sample for the given test key, and update the wave when pressing different keys. wave also doesn't change when tuning volume dial (but seems to update if you change instruments back and forth).

Dependencies

None.

Comments

No comments.

Add a comment